Skip to content

Do not assume every PositionsEvent has a PositionType.DEEBOT inside#955

Merged
edenhaus merged 2 commits into
DeebotUniverse:devfrom
nanomad:feature/fix-issue-953
May 9, 2025
Merged

Do not assume every PositionsEvent has a PositionType.DEEBOT inside#955
edenhaus merged 2 commits into
DeebotUniverse:devfrom
nanomad:feature/fix-issue-953

Conversation

@nanomad

@nanomad nanomad commented May 8, 2025

Copy link
Copy Markdown
Contributor

Fixes #953

@codecov

codecov Bot commented May 8, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.31%. Comparing base (5b6d68b) to head (b1a471a).
Report is 3 commits behind head on dev.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #955      +/-   ##
==========================================
+ Coverage   93.15%   93.31%   +0.15%     
==========================================
  Files         128      128              
  Lines        4995     4993       -2     
  Branches      331      330       -1     
==========================================
+ Hits         4653     4659       +6     
+ Misses        282      274       -8     
  Partials       60       60              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq

codspeed-hq Bot commented May 8, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #955 will not alter performance

Comparing nanomad:feature/fix-issue-953 (b1a471a) with dev (e9c66b6)

Summary

✅ 6 untouched benchmarks

@edenhaus edenhaus added the pr: bugfix PR, which fixes a bug label May 9, 2025

@edenhaus edenhaus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nanomad 👍

@edenhaus edenhaus enabled auto-merge (squash) May 9, 2025 14:18
@edenhaus edenhaus merged commit 2b18d80 into DeebotUniverse:dev May 9, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: bugfix PR, which fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

XML Bots: StopIteration raised on ChargerPos command result

2 participants